pgwire: lazily populate second timezone offset #57265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like cockroachdb#55071 was too greedy -- looks like (at the very least) pgjdbc expects the second offset to only be displayed if there is a second offset. It's easy to do, so I have done so. Fixed TimeTZ along the way. Release note (bug fix): Second timezone offsets for TimeTZ now correctly display over the postgres wire protocol - these were previously omitted. Release note (bug fix): Second timezone offsets are only displayed in the postgres wire protocol for TimestampTZ values. In an earlier patch for v21.1, this would always display.
|
This change is |
rafiss
approved these changes
Dec 1, 2020
|
bors r=rafiss |
|
Build succeeded: |
rafiss
added a commit
to rafiss/cockroach
that referenced
this pull request
May 12, 2021
Similar to cockroachdb#57265, this commit matches the PG behavior to only show the minutes offset if it is non-zero. Release note (bug fix): Minute timezone offsets are only displayed in the wire protocol if they are non-zero for TimestampTZ and TimeTZ values. Previously, they would always display. Release note (bug fix): Binary TimeTZ values were not being decoded correctly when being sent as a parameter in the wire protocol. This is now fixed.
rafiss
added a commit
to rafiss/cockroach
that referenced
this pull request
May 12, 2021
Similar to cockroachdb#57265, this commit matches the PG behavior to only show the minutes offset if it is non-zero. Release note (bug fix): Minute timezone offsets are only displayed in the wire protocol if they are non-zero for TimestampTZ and TimeTZ values. Previously, they would always display. Release note (bug fix): Binary TimeTZ values were not being decoded correctly when being sent as a parameter in the wire protocol. This is now fixed.
craig bot
pushed a commit
that referenced
this pull request
May 17, 2021
65063: pgwire: only show TZ minutes offset if non-zero r=otan a=rafiss Similar to #57265, this commit matches the PG behavior to only show the minutes offset if it is non-zero. Release note (bug fix): Minute timezone offsets are only displayed in the wire protocol if they are non-zero for TimestampTZ and TimeTZ values. Previously, they would always display. Release note (bug fix): Binary TimeTZ values were not being decoded correctly when being sent as a parameter in the wire protocol. This is now fixed. Release note (cli change): The SQL shell now formats times with time zones so that the minutes and seconds offsets are only shown if they are non-zero. Also, infinite floating point values are formatted as `Infinity` rather than `Inf` now. Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
rafiss
added a commit
to rafiss/cockroach
that referenced
this pull request
May 17, 2021
Similar to cockroachdb#57265, this commit matches the PG behavior to only show the minutes offset if it is non-zero. Release note (bug fix): Minute timezone offsets are only displayed in the wire protocol if they are non-zero for TimestampTZ and TimeTZ values. Previously, they would always display. Release note (bug fix): Binary TimeTZ values were not being decoded correctly when being sent as a parameter in the wire protocol. This is now fixed.
knz
pushed a commit
to knz/cockroach
that referenced
this pull request
Jun 8, 2021
Similar to cockroachdb#57265, this commit matches the PG behavior to only show the minutes offset if it is non-zero. Release note (bug fix): Minute timezone offsets are only displayed in the wire protocol if they are non-zero for TimestampTZ and TimeTZ values. Previously, they would always display. Release note (bug fix): Binary TimeTZ values were not being decoded correctly when being sent as a parameter in the wire protocol. This is now fixed.
knz
pushed a commit
to knz/cockroach
that referenced
this pull request
Jul 22, 2021
Similar to cockroachdb#57265, this commit matches the PG behavior to only show the minutes offset if it is non-zero. Release note (bug fix): Minute timezone offsets are only displayed in the wire protocol if they are non-zero for TimestampTZ and TimeTZ values. Previously, they would always display. Release note (bug fix): Binary TimeTZ values were not being decoded correctly when being sent as a parameter in the wire protocol. This is now fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #55071 was too greedy -- looks like (at the very least)
pgjdbc expects the second offset to only be displayed if there is a
second offset. It's easy to do, so I have done so.
Fixed TimeTZ along the way.
Refs #57168
Release note (bug fix): Second timezone offsets for TimeTZ now
correctly display over the postgres wire protocol - these were
previously omitted.
Release note (bug fix): Second timezone offsets are only displayed in
the postgres wire protocol for TimestampTZ values. In an earlier patch
for v21.1, this would always display.