release-20.2: opt: disallow aggregate/window functions in ORDER BY for UNION #57521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We support aggregates in ORDER BY, but only in the context of a SELECT. If we have an ORDER BY clause outside a UNION or VALUES, this results in an internal error (caused by a Project that tries to pass through columns not in input). This change presents a proper error for this case. Note that pg also errors out in these cases. Note: I am adding a CheckExpr assertion for Project in a separate PR (it found more issues). Fixes cockroachdb#57441. Release note (bug fix): fixed an internal error when using aggregates and window functions in an ORDER BY for a UNION or VALUES clause.
|
This change is |
mgartner
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #57498.
/cc @cockroachdb/release
We support aggregates in ORDER BY, but only in the context of a
SELECT. If we have an ORDER BY clause outside a UNION or VALUES, this
results in an internal error (caused by a Project that tries to pass
through columns not in input).
This change presents a proper error for this case. Note that pg also
errors out in these cases.
Note: I am adding a CheckExpr assertion for Project in a separate PR
(it found more issues).
Fixes #57441.
Release note (bug fix): fixed an internal error when using aggregates
and window functions in an ORDER BY for a UNION or VALUES clause.