release-20.1: opt: fix panic caused by some DDL statements and CTEs #57952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rytaft
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
This piece of code assumed that all MutationOps have a MutationPrivate, which is not the case (only the DMLs have it). It causes a panic if we try to derive WithUses. Fixes cockroachdb#57821. Release note (bug fix): fixed assertion error caused by some DDL statements used in conjunction with common table expressions (WITH).
RaduBerinde
force-pushed
the
backport20.1-57927
branch
from
cf313fa
to
4eb2bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #57927.
/cc @cockroachdb/release
This piece of code assumed that all MutationOps have a
MutationPrivate, which is not the case (only the DMLs have it). It
causes a panic if we try to derive WithUses.
Fixes #57821.
Release note (bug fix): fixed assertion error caused by some DDL
statements used in conjunction with common table expressions (WITH).