release-20.1: sql: make information_schema.statistics deterministic #58215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
force-pushed
the
backport20.1-58191
branch
from
75f0e82
to
a33470f
Compare
rafiss
approved these changes
Dec 23, 2020
yuzefovich
force-pushed
the
backport20.1-58191
branch
2 times, most recently
from
7863cef
to
b6e9927
Compare
Previously, "implicit" columns could be added to the `information_schema.statistics` virtual table in an arbitray order since we were iterating over a map when adding them. This is unfortunate since some schema inspection tools might rely on the output being deterministic. Release note (bug fix): Previously, CockroachDB could return non-deterministic output when querying `information_schema.statistics` virtual table (internally used by `SHOW INDEXES` command) - namely, the implicit columns of the secondary indexes could be in arbitrary order. This is now fixed, and the columns will be in the same order as they are in the primary index.
yuzefovich
force-pushed
the
backport20.1-58191
branch
from
b6e9927
to
677883b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #58191.
/cc @cockroachdb/release
Previously, "implicit" columns could be added to the
information_schema.statisticsvirtual table in an arbitray order sincewe were iterating over a map when adding them. This is unfortunate since
some schema inspection tools might rely on the output being
deterministic.
Release note (bug fix): Previously, CockroachDB could return
non-deterministic output when querying
information_schema.statisticsvirtual table (internally used by
SHOW INDEXEScommand) - namely, theimplicit columns of the secondary indexes could be in arbitrary order.
This is now fixed, and the columns will be in the same order as they are
in the primary index.