release-20.1: sql: catch panics from SHOW STATISTICS code #58264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a panic catcher around the code that processes the statistics for SHOW STATISTICS. This statement is used internally for statement diagnostics, so a crash here can be very bad. Informs cockroachdb#58220. Informs cockroachdb#56356. Release note (bug fix): added a safeguard against crashes while running `SHOW STATISTICS USING JSON`, which is used internally for statement diagnostics and EXPLAIN ANALYZE (DEBUG).
|
This change is |
rytaft
approved these changes
Dec 24, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #58221.
/cc @cockroachdb/release
This change adds a panic catcher around the code that processes the
statistics for SHOW STATISTICS. This statement is used internally for
statement diagnostics, so a crash here can be very bad.
Informs #58220.
Informs #56356.
Release note (bug fix): added a safeguard against crashes while
running
SHOW STATISTICS USING JSON, which is used internally forstatement diagnostics and EXPLAIN ANALYZE (DEBUG).