release-20.2: demo: fix --global option #58626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
backport20.2-58466
branch
from
64ef52f
to
9110257
Compare
The --global option broke somewhere during the 20.2 cycle. This patch revives it. --global simulates geo-latencies between nodes. Best used with `--global --geo-partitioned-replicas`. Release note (cli change): fix cockroach demo --global from crashing with "didn't get expected magic bytes header".
otan
force-pushed
the
backport20.2-58466
branch
from
9110257
to
513d3c3
Compare
nvanbenschoten
approved these changes
Jan 8, 2021
| @@ -2,10 +2,13 @@ | |||
|
|
|||
| source [file join [file dirname $argv0] common.tcl] | |||
|
|
|||
| # Set a larger timeout since we are going global. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/2 commits from #58466.
/cc @cockroachdb/release
The --global option broke somewhere during the 20.2 cycle. This patch
revives it. --global simulates geo-latencies between nodes. Best used
with
--global --geo-partitioned-replicas.Release note (cli change): fix cockroach demo --global from crashing
with "didn't get expected magic bytes header".