Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-20.1: *: Upgrade gogoproto #58861

Merged
merged 1 commit into from
Jan 12, 2021
Merged

release-20.1: *: Upgrade gogoproto #58861

merged 1 commit into from
Jan 12, 2021

Conversation

bdarnell
Copy link
Contributor

@bdarnell bdarnell commented Jan 12, 2021 •
edited by knz
Loading

Backport 1/1 commit from #58716.

cc @cockroachdb/release

@bdarnell
*: Upgrade gogoproto
693aa59 
Release note (bug fix): Fix a panic in protobuf decoding
@bdarnell bdarnell requested review from a team as code owners January 12, 2021 15:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

knz
knz approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was initially surprised to see so many files changed in the vendor tree, but they are all generated .pb.go. So LGTM

@aaron-crl
Copy link

aaron-crl commented Jan 12, 2021 •
edited by petermattis
Loading

I was initially surprised to see so many files changed in the vendor tree, but they are all generated .pb.go. So LGTM

same :lgtm:

@knz
Copy link
Contributor

knz commented Jan 12, 2021

this is green so merging

@knz knz merged commit 5197d58 into cockroachdb:release-20.1 Jan 12, 2021
@bdarnell bdarnell deleted the skippy-20.1 branch January 12, 2021 18:02
@bdarnell
Copy link
Contributor Author

Oops, thought I had already done that.

@knz knz changed the title *: Upgrade gogoproto release-20.1: *: Upgrade gogoproto Jan 13, 2021
@knz knz mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knz knz knz approved these changes

@celiala celiala Awaiting requested review from celiala

@aaron-crl aaron-crl Awaiting requested review from aaron-crl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bdarnell @cockroach-teamcity @aaron-crl @knz