Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.2: build: always specify PORTABLE=1 when building RocksDB #59017

Commits on Jan 14, 2021

  1. build: always specify PORTABLE=1 when building RocksDB

    Something recently changed on the TC agents (presumably usage of a new
    machine type with a different CPU) so that using `-march=native` when
    building RocksDB causes AVX512 instructions to be used which are not
    present on roachprod machines. The result is that binaries built in this
    way will die with "illegal instruction". RocksDB has a mechanism to
    disable the use of `-march=native`: pass `PORTABLE=1` to the make
    command. We were already doing this for release builds. Now we're doing
    it for all builds.
    
    Fixes cockroachdb#58754
    
    Release note: none
    petermattis committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    973602e View commit details
    Browse the repository at this point in the history