sql: properly qualify the names of dropped views

[the-ericwang35]

Fixes #57735.

Previously, event logs were not capturing the
fully qualified names of dropped views.
This PR changes the event logs to use the fully
qualified view names.
Tests were also updated to reflect this change.

Release note (bug fix): add qualification prefix for dropped views.

[cockroach-teamcity]

This change is 

[thoszhang]

Reviewed 17 of 17 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @the-ericwang35)

---

pkg/sql/resolver.go, line 405 at r1 (raw file):

// reverse of the Resolve() functions.
func (p *planner) getQualifiedTableName(
	ctx context.Context, desc catalog.TableDescriptor, flags tree.DatabaseLookupFlags,

I think we should just always set IncludeOffline and IncludeDropped to true and assume that the caller is fine with resolving a name for something dropped earlier in the transaction, instead of allowing callers to pass in flags. (NB: the GetImmutable methods try to resolve a leased descriptor unless AvoidCached is set. But dropped and offline descriptors can't be leased, so we just end up resolving the descriptor from the store every time. But that's fine.)

[the-ericwang35]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @lucy-zhang)

---

pkg/sql/resolver.go, line 405 at r1 (raw file):

Previously, lucy-zhang (Lucy Zhang) wrote…

I think we should just always set IncludeOffline and IncludeDropped to true and assume that the caller is fine with resolving a name for something dropped earlier in the transaction, instead of allowing callers to pass in flags. (NB: the GetImmutable methods try to resolve a leased descriptor unless AvoidCached is set. But dropped and offline descriptors can't be leased, so we just end up resolving the descriptor from the store every time. But that's fine.)

Sure sounds good, I've changed it to always set IncludeOffline and IncludeDropped to be true

[thoszhang]

Reviewed 16 of 16 files at r2.
Reviewable status: complete! 0 of 0 LGTMs obtained

[the-ericwang35]

TFTR!

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)