cli/debug: make ballast unable to overwrite existing files
#59995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @joshimhoff)
stevendanna
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:
|
thanks! bors r=tbg,stevendanna |
|
Build failed: |
|
💯 |
Release note (backward-incompatible change): The `cockroach debug ballast` command now refuses to overwrite the target ballast file if it already exists. This change is intended to prevent mistaken uses of the `ballast` command by operators. Scripts that integrate `cockroach debug ballast` can consider adding a `rm` command.
|
that was a lint error bors r=tbg,stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in customer postmortem.
Release note (backward-incompatible change): The
cockroach debug ballastcommand now refuses to overwrite the target ballast file ifit already exists. This change is intended to prevent mistaken uses of
the
ballastcommand by operators. Scripts that integratecockroach debug ballastcan consider adding armcommand.