*,bazel: support dev test pkg/{...} expansion
#60558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
alan-mas
approved these changes
Feb 16, 2021
|
lgtm+ =) |
I think I took care of this in a commit last week (probably at around the same time as you), so this can probably be removed from the msg? |
|
whoops lmao |
rickystewart
approved these changes
Feb 17, 2021
irfansharif
force-pushed
the
210212.bazel-fixups
branch
2 times, most recently
from
514bf35
to
e1c0411
Compare
|
Done, TFTR! bors r+ |
|
bors r- |
|
Canceled. |
Discovered these while trying to flesh out cockroachdb/dev#4. We're doing a few things in this commit: - Exclude the testdata dir under pkg/testutils from gazelle/bazel consideration - Fix a few incorrect package resolutions (they were pointing to testdata paths previously). Combining this with cockroachdb/dev#4, now we can use `go test` style "..." expansion in `dev`[*]: dev test pkg/util/... [*]: Though failing tests that are broken under Bazel. Release note: None
irfansharif
force-pushed
the
210212.bazel-fixups
branch
from
e1c0411
to
e3ce204
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered these while trying to flesh out cockroachdb/dev#4.
We're doing a few things in this commit:
consideration
testdata paths previously).
the test target (pkg/util/uuid -> pkg/testutils/skip -> pkg/util/uuid)
so flew by undetected earlier.
Combining this with cockroachdb/dev#4, now we
can use
go teststyle "..." expansion indev[*]:dev test pkg/util/...
[*]: Though failing tests that are broken under Bazel.
Release note: None