Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: implement ST_Affine for 3D transformations #61286

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

alsohas
Copy link
Contributor

@alsohas alsohas commented Mar 1, 2021

Resolves #60874.

Release justification: low risk addition to new functionality
Release note (sql change): The geography builtin ST_Affine now supports
3D transformations

@blathers-crl
Copy link

blathers-crl bot commented Mar 1, 2021

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Mar 1, 2021
@blathers-crl blathers-crl bot requested a review from otan March 1, 2021 20:55
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 1, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 1, 2021

Build failed (retrying...):

@yuzefovich
Copy link
Member

bors r-

Gotta make the linter happy.

@craig
Copy link
Contributor

craig bot commented Mar 1, 2021

Canceled.

Resolves cockroachdb#60874.

Release justification: low risk addition to new functionality
Release note (sql change): The geography builtin ST_Affine now supports
3D transformations
@blathers-crl
Copy link

blathers-crl bot commented Mar 1, 2021

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@otan
Copy link
Contributor

otan commented Mar 2, 2021

ah woops, sorry @yuzefovich!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 2, 2021

Build succeeded:

@craig craig bot merged commit d672710 into cockroachdb:master Mar 2, 2021
@alsohas alsohas deleted the st_affine branch March 2, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
4 participants