release-20.2: changefeedccl: remove unnecessary and/or impossible privilege checks #61661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changefeeds were checking the SELECT privilege on every descriptor associated with targeted tables, including the database (should not be required) and custom types (not possible to assign granularly). They now only check SELECT on the targeted tables itself. Release note (bug fix): Better privilege checks when creating a changefeed
HonoreDB
requested review from
ajwerner,
a team and
pbardea
and removed request for
a team
|
This change is |
ajwerner
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
I think this needs a 21.1 backport too
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @pbardea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #61031.
/cc @cockroachdb/release
Changefeeds were checking the SELECT privilege on every descriptor associated
with targeted tables, including the database (should not be required) and
custom types (not possible to assign granularly).
They now only check SELECT on the targeted tables itself.
Release note (bug fix): Better privilege checks when creating a changefeed
Closes #61006