release-20.2: sql/*: remove MakeTableName (without schema) function #61890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
In addition to the release note below, this also fixes the error message that would appear when trying to drop a role that owns a table in a user-defined schema. Release note (bug fix): Using EXPLAIN (OPT, ENV) on a query that references a table in a user-defined schema would fail previously. This is now fixed.
rafiss
force-pushed
the
backport20.2-61752
branch
from
25cc77d
to
f2821c4
Compare
solongordon
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/2 commits from #61752.
/cc @cockroachdb/release
This made it very easy to forget to account for user-defined schemas.
Removing the function should prevent a big class of bugs.
This is broken up into 2 commits. The first fixes some cases that appeared
to me as if they'd benefit from looking up the schema name, and is intended
for a backport back to 20.2. The second commit is a refactor that removes the
non-schema MakeTableName function and probably doesn't need to be backported.
In addition to the release note below, this also fixes the error message
that would appear when trying to drop a role that owns a table in a
user-defined schema.
Release note (bug fix): Using EXPLAIN (OPT, ENV) on a query that
references a table in a user-defined schema would fail previously. This
is now fixed.