release-21.1: sql: include non-voters in crdb_internal.ranges{_no_leases} #61962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the `replicas` column of
`crdb_internal.ranges_no_leases` would only included voting replicas.
This commit makes it such that it includes voting as well as non-voting
replicas.
Additionally, this commit also adds two new columns: `voting_replicas`
and `non_voting_replicas`.
Release justification: observability improvements for new functionality
Release note (sql change): the `replicas` column of
`crdb_internal.ranges{_no_leases}` now includes both voting and
non-voting replicas and `crdb_internal.ranges{_no_leases}` include two
new columns: `voting_replicas` and `non_voting_replicas` which work as
labelled.
|
This change is |
|
LGTM
…On Fri, Mar 12, 2021 at 6:40 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/61962>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#61962 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4C4JWGNM6V7PMEDJENCDTDKJ4TANCNFSM4ZDEVFBA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #59839.
/cc @cockroachdb/release
Before this commit, the
replicascolumn ofcrdb_internal.ranges_no_leaseswould only included voting replicas.This commit makes it such that it includes voting as well as non-voting
replicas.
Additionally, this commit also adds two new columns:
voting_replicasand
non_voting_replicas.Release justification: observability improvements for new functionality.
Release note: the
replicascolumn ofcrdb_internal.ranges{_no_leases}now includes both voting andnon-voting replicas and
crdb_internal.ranges{_no_leases}include twonew columns:
voting_replicasandnon_voting_replicaswhich work aslabelled.