release-20.2: filetable: fix race in userfile table creation #62547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, userfile would create the userfile table in a separate transaction from the one that checked to see if it existed. This lead to a potential race between concurrent userfile uploads where one upload would first see that the table does not yet exist, but by the time it went to create the table another thread had already created it. This lead to some file writes erroring with a relation already exists error. Release note (bug fix): Writing files to userfile would sometimes results in an error claiming that the userfile table already exists. This is now fixed.
|
This change is |
adityamaru
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #62461.
/cc @cockroachdb/release
Previously, userfile would create the userfile table in a separate
transaction from the one that checked to see if it existed. This lead to
a potential race between concurrent userfile uploads where one upload
would first see that the table does not yet exist, but by the time it
went to create the table another thread had already created it.
This lead to some file writes erroring with a relation already exists
error.
Fixes #61816.
Release note (bug fix): Writing files to userfile would sometimes
results in an error claiming that the userfile table already exists.
This is now fixed.