release-20.2: opt: fix internal error when calculating stats for mutation passthrough cols #62961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
…gh cols Prior to this commit, an attempt to calculate statistics for a passthrough column in a mutation would cause an error, since passthrough columns were inadvertently ignored by the MapToInputCols function. This commit fixes the problem by updating MapToInputCols so that it checks whether any of the given columns are in PassthroughCols before trying to map them to a table column. Fixes cockroachdb#62692 Release note (bug fix): Fixed an internal error that could occur during planning when a query used the output of an UPDATE's RETURNING clause, and one or more of the columns in the RETURNING clause were from a table specified in the FROM clause of the UPDATE (i.e., not from the table being updated).
rytaft
force-pushed
the
backport20.2-62921
branch
from
e3de5bb
to
2f90d8b
Compare
mgartner
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #62921.
/cc @cockroachdb/release
Prior to this commit, an attempt to calculate statistics for a passthrough
column in a mutation would cause an error, since passthrough columns were
inadvertently ignored by the
MapToInputColsfunction. This commit fixesthe problem by updating
MapToInputColsso that it checks whether any of thegiven columns are in
PassthroughColsbefore trying to map them to a tablecolumn.
Fixes #62692
Release note (bug fix): Fixed an internal error that could occur during
planning when a query used the output of an UPDATE's RETURNING clause,
and one or more of the columns in the RETURNING clause were from a table
specified in the FROM clause of the UPDATE (i.e., not from the table being
updated).