release-21.1: sql: copy VIRTUAL columns in CREATE TABLE LIKE #63172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where a `VIRTUAL` column in a source table would be copied as a `STORED` column in the destination table in a `CREATE TABLE LIKE` expression. Fixes cockroachdb#63167 Release note (bug fix): Previously, CREATE TABLE LIKE would copy a VIRTUAL column from the source table as a STORED colum in the destination table. This bug, which is only present in pre-release 21.1 versions, has been fixed.
|
This change is |
RaduBerinde
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rytaft and @yuzefovich)
rytaft
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #63171.
/cc @cockroachdb/release
This commit fixes a bug where a
VIRTUALcolumn in a source table wouldbe copied as a
STOREDcolumn in the destination table in aCREATE TABLE LIKEexpression.Fixes #63167
Release note (bug fix): Previously, CREATE TABLE LIKE would copy a
VIRTUAL column from the source table as a STORED colum in the
destination table. This bug, which is only present in pre-release 21.1
versions, has been fixed.