Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cliccl/load.go: update --as-of to display backup data at arbitrary timestamp #63181

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

Elliebababa
Copy link
Contributor

Previously, --as-of flag only allows users to inspect data of an
exact backup timestamp.

This patch improves --as-of to work with backup with
revision history to enable users to inpect data of an arbitrary
timestamp.

Release note (cli change): --as-of of load show data had
restriction that users can only inspect data at an exact backup
timestamp. Now we improve the flag to work with backup with
revision history so that users can inspect data of an arbitrary
timestamp.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@Elliebababa Elliebababa force-pushed the aost_with_revision_history branch 2 times, most recently from 6dad34d to e9e3b69 Compare April 7, 2021 14:44
@Elliebababa Elliebababa requested a review from pbardea April 7, 2021 16:01
@Elliebababa Elliebababa marked this pull request as ready for review April 7, 2021 19:24
@Elliebababa Elliebababa requested a review from a team April 7, 2021 19:24
Copy link
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple of nits

pkg/ccl/backupccl/targets.go Show resolved Hide resolved
pkg/sql/row/kv_fetcher.go Outdated Show resolved Hide resolved
Previously, `--as-of` flag only allows users to inspect data of an
exact backup timestamp.

This patch improves `--as-of` to work with backup with
revision history to enable users to inpect data of an arbitrary
timestamp.

Release note (cli change): `--as-of` of `load show data` had
restriction that users can only inspect data at an exact backup
timestamp. Now we improve the flag to work with backup with
revision history so that users can inspect data of an arbitrary
timestamp.
@Elliebababa
Copy link
Contributor Author

bors r=pbardea

@craig
Copy link
Contributor

craig bot commented Apr 12, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants