release-21.1: sql: fix dropping zone configs from REGIONAL BY ROW during failure #63274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added some more useful error messaging + fixed validation to use NonDropIndexes as Active, which is in line with how the ApplyOption function works. Also refactored the placeholder zone config logic when deleting the last subzone to work in the new world. Release note (bug fix): Fix a bug where REGIONAL BY ROW zone configs were dropped before REGIONAL BY ROW changes are finalised. This causes a bug when the REGIONAL BY ROW transformation fail.
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #63200.
/cc @cockroachdb/release
Also added some more useful error messaging + fixed validation to use
NonDropIndexes as Active, which is in line with how the ApplyOption
function works.
Resolves: #63201
Release note (bug fix): Fix a bug where REGIONAL BY ROW zone configs
were dropped before REGIONAL BY ROW changes are finalised. This causes a
bug when the REGIONAL BY ROW transformation fail.