changefeedccl: Make kafka_sink_config a valid option.
#63857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
stevendanna
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @miretskiy)
a discussion (no related file):
Feels like there might be some unit testing we are missing given how we had to wedge a test for this into the error testing, but let's leave that for later as I imagine we might have to restructure some code to improve the situation.
|
Agreed. We need better unit testable kafka. We don't have any kafka tests on changefeed statement level. |
Add `kafka_sink_config` to the list of allowed changefeed options. Release Notes: None
|
tftr |
|
Build succeeded: |
This was referenced Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
kafka_sink_configto the list of allowed changefeed options.Release Notes: None