add generate_series for timestampTZ values

[oeph]

This change adds generate_series(timestamptz, timestamptz, interval) as it is also supported by postgres

Fixes #64850

[blathers-crl]

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

• @RaduBerinde (author of sql: implement generate_series for timestamps #64850)

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[cockroach-teamcity]

This change is 

[RaduBerinde]

Thanks for the contribution!

If you can, it would be great to also add a (timestamp, timestamp, interval) version, so we don't have to come back to it later.

Could you add a test like the one below (inspired from #64722)?

set timezone='Europe/Bucharest';
select '2020-10-25 00:00'::TIMESTAMPTZ + (i::text || ' hour')::interval from generate_series(0, 24) AS g(i);
select t from generate_series('2020-10-25 00:00'::TIMESTAMPTZ, '2020-10-26 00:00'::TIMESTAMPTZ, '1 hour');

These two statements should return the same results (might need to adjust the end time so they return the same number of rows).

[oeph]

sure, will do!

[oeph]

@RaduBerinde isn't the (timestamp, timestamp, interval) one already supported? https://github.com/cockroachdb/cockroach/blob/fcb7d81a26a8be25cf28219a148f87ead3742109/pkg/sql/sem/builtins/generator_builtins.go#L128-L134

[blathers-crl]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[oeph]

I added the test case that you suggested

[RaduBerinde]

Ah, sorry, I guess it is already implemented.

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @oeph, @otan, and @yuzefovich)

---

pkg/sql/logictest/testdata/logic_test/builtin_function, line 3021 at r1 (raw file):

SET TIME ZONE +0

statement ok

This only tests that we don't crash.. We should use query to see the output so we can confirm that the two are equivalent.

[oeph]

@RaduBerinde is there a way to automatically compare the outputs of both query to match? I can't find any for the sqllogictest - can you maybe give me a hint? Or should I just add these both queries as standalone queries?

[RaduBerinde]

Ah, it's not necessary, we can just visually compare. We can leave a comment saying that the results should be the same if they ever were to change. We review any changes to these files.

[oeph]

@RaduBerinde I added a comment for this

[RaduBerinde]

Thank you!

bors r+

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @oeph, @otan, and @yuzefovich)

[craig]

Build succeeded:

• GitHub CI (Cockroach)

[otan]

thanks @oeph !