release-20.2: sql: fix ordered set aggregates with constant ORDER BY expressions #64903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug that caused an error when providing a constant ORDER BY expressions in an ordered set aggregate. Fixes cockroachdb#64319 Fixes cockroachdb#64318 Release note (bug fix): Providing a constant value as an ORDER BY value in an ordered set aggregate, such as `percentile_dist` or `percentile_cont`, no longer errors. This bug has been present since order set aggregates were added in version 20.2.
|
This change is |
RaduBerinde
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #64892.
/cc @cockroachdb/release
This commit fixes a bug that caused an error when providing a constant
ORDER BY expressions in an ordered set aggregate.
Fixes #64319
Fixes #64318
Release note (bug fix): Providing a constant value as an ORDER BY value
in an ordered set aggregate, such as
percentile_distorpercentile_cont, no longer errors. This bug has been present sinceorder set aggregates were added in version 20.2.