release-21.1: sql: fix has_database_privilege to work cross-DB #65534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fixed using the `"".crdb_internal.table` syntax for name resolution, which is well-defined, and causes metadata from all databases to appear in the crdb_internal virtual schema. Release note (bug fix): The has_database_privilege function now correctly will check privileges on databases that are not the current database being used by the session.
|
This change is |
RichardJCai
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #65513.
/cc @cockroachdb/release
fixes #65421
This is fixed using the
"".crdb_internal.tablesyntax for nameresolution, which is well-defined, and causes metadata from all
databases to appear in the crdb_internal virtual schema.
Release note (bug fix): The has_database_privilege function now
correctly will check privileges on databases that are not the current
database being used by the session.