Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/cloud: remove CloseWithError #65660

Merged
merged 1 commit into from
May 25, 2021
Merged

storage/cloud: remove CloseWithError #65660

merged 1 commit into from
May 25, 2021

Commits on May 25, 2021

  1. storage/cloud: remove CloseWithError 

    Context cancellation is typically how operations are aborted.
When we open a new Writer, we pass a context, so we must assume
that that context can be cancelled, which should cancel the write
operation. Having an extra CloseWithError method in the API that
also cancels the operation is duplicative.

Release note: none.
    @dt
    dt committed May 25, 2021
    Configuration menu
    Copy the full SHA
    771a2af View commit details
    Browse the repository at this point in the history