build: explicitly specify the host compilers for cmake
#65745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
When cross-compiling, we specify a `CMAKE_{CC,CXX}_COMPILER`, but we
don't do the same for the host `protobuf` build.
We happen to have been encountering compile errors on this part of the
build related to `cmake` being unable to find an appropriate C/C++
compiler in a non-deterministic way (see cockroachdb#65716). I don't know enough
about `cmake` to be able to describe why that's happening all of a
sudden, but we can avoid the confusion by directly specifying the
compilers ourselves.
Release note: None
rail
approved these changes
May 26, 2021
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
|
bors r=rail |
|
Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling, we specify a
CMAKE_{CC,CXX}_COMPILER, but wedon't do the same for the host
protobufbuild.We happen to have been encountering compile errors on this part of the
build related to
cmakebeing unable to find an appropriate C/C++compiler in a non-deterministic way (see #65716). I don't know enough
about
cmaketo be able to describe why that's happening all of asudden, but we can avoid the confusion by directly specifying the
compilers ourselves.
Release note: None