New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
importccl: respect storage options on PGDUMP index creation #66903
importccl: respect storage options on PGDUMP index creation #66903
Conversation
7c7d0fb
to
8bfea97
Compare
IMPORT now detects the storage params that can be specified on a CREATE INDEX statement from a PGDUMP file. See https://www.cockroachlabs.com/docs/stable/create-index.html for more details about storage options that can be specified on indexes. Release note (bug fix): IMPORT now respects the spacial index storage options specified in PGDUMP files on indexes it creates. Release justification: bug fix. IMPORT now respects the spacial index storage options specified in PGDUMP files on indexes it creates.
8bfea97
to
00bb5f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded: |
blathers backport 21.2 21.1 20.2 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 00bb5f2 to blathers/backport-release-20.2-66903: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 20.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Heads-up that it looks like this broke Bazel CI (if I'm interpreting this result correctly): https://teamcity.cockroachdb.com/viewLog.html?buildId=3533779&buildTypeId=Cockroach_UnitTests_BazelUnitTests @otan - wanna take a look? |
IMPORT now detects the storage params that can be specified on a CREATE
INDEX statement from a PGDUMP file. See
https://www.cockroachlabs.com/docs/stable/create-index.html for more
details about storage options that can be specified on indexes.
Release note (bug fix): IMPORT now respects the spacial index storage
options specified in PGDUMP files on indexes it creates.