Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importccl: respect storage options on PGDUMP index creation #66903

Merged
merged 1 commit into from Oct 4, 2021

Conversation

pbardea
Copy link
Contributor

@pbardea pbardea commented Jun 25, 2021

IMPORT now detects the storage params that can be specified on a CREATE
INDEX statement from a PGDUMP file. See
https://www.cockroachlabs.com/docs/stable/create-index.html for more
details about storage options that can be specified on indexes.

Release note (bug fix): IMPORT now respects the spacial index storage
options specified in PGDUMP files on indexes it creates.

@pbardea pbardea requested review from a team and adityamaru and removed request for a team June 25, 2021 19:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pbardea pbardea force-pushed the geospacial-index-storage-options branch from 7c7d0fb to 8bfea97 Compare June 25, 2021 19:42
@pbardea pbardea removed the request for review from adityamaru June 28, 2021 13:12
@pbardea pbardea marked this pull request as draft June 28, 2021 13:12
@pbardea pbardea self-assigned this Jul 16, 2021
IMPORT now detects the storage params that can be specified on a CREATE
INDEX statement from a PGDUMP file. See
https://www.cockroachlabs.com/docs/stable/create-index.html for more
details about storage options that can be specified on indexes.

Release note (bug fix): IMPORT now respects the spacial index storage
options specified in PGDUMP files on indexes it creates.

Release justification: bug fix. IMPORT now respects the spacial index
storage options specified in PGDUMP files on indexes it creates.
@pbardea pbardea force-pushed the geospacial-index-storage-options branch from 8bfea97 to 00bb5f2 Compare August 25, 2021 18:35
@pbardea pbardea marked this pull request as ready for review August 25, 2021 18:35
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 4, 2021

Build succeeded:

@craig craig bot merged commit ff7f80f into cockroachdb:master Oct 4, 2021
@otan
Copy link
Contributor

otan commented Oct 4, 2021

blathers backport 21.2 21.1 20.2

@blathers-crl
Copy link

blathers-crl bot commented Oct 4, 2021

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 00bb5f2 to blathers/backport-release-20.2-66903: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 20.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@ajstorm
Copy link
Collaborator

ajstorm commented Oct 4, 2021

Heads-up that it looks like this broke Bazel CI (if I'm interpreting this result correctly): https://teamcity.cockroachdb.com/viewLog.html?buildId=3533779&buildTypeId=Cockroach_UnitTests_BazelUnitTests

@otan - wanna take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants