Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: surface the transaction restarts chart #66973

Merged
merged 1 commit into from
Jun 28, 2021
Merged

ui: surface the transaction restarts chart #66973

merged 1 commit into from
Jun 28, 2021

Conversation

matthewtodd
Copy link
Contributor

@matthewtodd matthewtodd commented Jun 28, 2021

Resolves #65856

Release note (ui change): The KV transaction restarts chart was moved from the "distributed" metrics to the "sql" metrics page so as to be close to the SQL transactions chart, for more prominent visibility.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@matthewtodd matthewtodd changed the title ui: add a transaction restarts chart ui: surface a transaction restarts chart Jun 28, 2021
@matthewtodd matthewtodd changed the title ui: surface a transaction restarts chart ui: surface the transaction restarts chart Jun 28, 2021
@matthewtodd matthewtodd requested a review from a team June 28, 2021 17:27
@matthewtodd matthewtodd marked this pull request as ready for review June 28, 2021 17:49
Resolves #65856

Release note (ui change): The KV transaction restarts chart was moved
from the "distributed" metrics to the "sql" metrics page so as to be
close to the SQL transactions chart, for more prominent visibility.
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Copy link
Contributor

@Azhng Azhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained

@matthewtodd
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 28, 2021

Build succeeded:

@craig craig bot merged commit 045d42e into cockroachdb:master Jun 28, 2021
@matthewtodd matthewtodd deleted the 65856-txn-retries-chart branch June 30, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants