Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: add exportrequest.delay.total metric #67310

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

pbardea
Copy link
Contributor

@pbardea pbardea commented Jul 7, 2021

This commit adds a metric to track how long export requests are blocked
by the concurrency limiter.

Release note (ops change): Introduce a new metric
(exportrequest.delay.total) to track how long ExportRequests (issued by
BACKUP) are delayed by throttling mechansisms.

@pbardea pbardea requested a review from dt July 7, 2021 14:17
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit adds a metric to track how long export requests are blocked
by the concurrency limiter.

Release note (ops change): Introduce a new metric
(exportrequest.delay.total) to track how long ExportRequests (issued by
BACKUP) are delayed by throttling mechansisms.
@pbardea
Copy link
Contributor Author

pbardea commented Jul 9, 2021

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Jul 9, 2021

Build failed:

@pbardea
Copy link
Contributor Author

pbardea commented Jul 9, 2021

Looks like it hit a flake, going to give it another go.
bors r+

@craig
Copy link
Contributor

craig bot commented Jul 9, 2021

Build succeeded:

@craig craig bot merged commit 64cedaf into cockroachdb:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants