server: use actual TenantID for multi-tenant KV admission control #67533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Informs cockroachdb#65954 Release note (ops change): Enabling admission.kv.enabled may provide better inter-tenant isolation for multi-tenant KV nodes.
|
This change is |
sumeerbhola
commented
Jul 13, 2021
There was a problem hiding this comment.
There are no experiments yet to measure effectiveness in multi-tenant settings. Those will come later (and are mentioned in the corresponding issue).
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @RaduBerinde)
RaduBerinde
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Reviewable status:
ajwerner
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
|
TFTRs! |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #65954
Release note (ops change): Enabling admission.kv.enabled may provide
better inter-tenant isolation for multi-tenant KV nodes.