Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.2: sql: require placeholder types to be identical to use a cached plan #67687

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 15, 2021

Backport 1/1 commits from #67651 on behalf of @rafiss.

/cc @cockroachdb/release

Release justification: low-impact but high-reward bug fix.


fixes #67605

Release note (bug fix): Fix a bug where a prepared statement could
incorrectly reuse the query plan of a different prepared statements that
had similar, but not identical type hints.


Release note (bug fix): Fix a bug where a prepared statement could
incorrectly reuse the query plan of a different prepared statements that
had similar, but not identical type hints.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-20.2-67651 branch from c472a35 to 6637a33 Compare July 15, 2021 21:08
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 15, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator

rafiss commented Sep 13, 2021

@RaduBerinde or @yuzefovich friendly ping on reviewing this

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missed it. :lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)

@rafiss rafiss merged commit 15b962c into release-20.2 Sep 13, 2021
@rafiss
Copy link
Collaborator

rafiss commented Sep 13, 2021

tftr!

@rafiss rafiss deleted the blathers/backport-release-20.2-67651 branch September 13, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants