sql: added empty stubs for pg_stat* tables #67947
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
mnovelodou
force-pushed
the
pg-stat-tables
branch
from
d650412
to
82637bb
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
mnovelodou
force-pushed
the
pg-stat-tables
branch
from
82637bb
to
d6fa0c7
Compare
Previously, pg_catalog didn't include pg_stat* empty stubs This was inadequate because tools try to use these tables and fail To address this, this patch adds empty stubs for pg_stats tables Release note (sql change): Added empty pg_stat* tables on pg_catalog pg_stat_all_indexes pg_stat_all_tables pg_stat_archiver pg_stat_bgwriter pg_stat_gssapi pg_stat_progress_analyze pg_stat_progress_basebackup pg_stat_progress_cluster pg_stat_progress_create_index pg_stat_progress_vacuum pg_stat_replication pg_stat_slru pg_stat_ssl pg_stat_subscription pg_stat_sys_indexes pg_stat_sys_tables pg_stat_user_functions pg_stat_user_indexes pg_stat_user_tables pg_stat_wal_receiver pg_stat_xact_all_tables pg_stat_xact_sys_tables pg_stat_xact_user_functions pg_stat_xact_user_tables pg_statio_all_indexes pg_statio_all_sequences pg_statio_all_tables pg_statio_sys_indexes pg_statio_sys_sequences pg_statio_sys_tables pg_statio_user_indexes pg_statio_user_sequences pg_statio_user_tables Fixes cockroachdb#67690
mnovelodou
force-pushed
the
pg-stat-tables
branch
from
d6fa0c7
to
9e2fea3
Compare
There was a problem hiding this comment.
this looks good! i had a question which we can address in a separate PR if needed.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @kevin-v-ngo and @mnovelodou)
pkg/sql/testdata/postgres_test_expected_diffs_on_pg_catalog.json, line 153 at r1 (raw file):
"pg_statistic_ext_data": {}, "pg_stats": {}, "pg_stats_ext": {},
do you know why these 4 tables are still not able to be generates with stubs?
There was a problem hiding this comment.
Reviewable status:
pkg/sql/testdata/postgres_test_expected_diffs_on_pg_catalog.json, line 153 at r1 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
do you know why these 4 tables are still not able to be generates with stubs?
This is because unmapped missing datatypes, you may see:
https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/testdata/pg_catalog_tables_from_postgres.json
|
bors r+ |
|
Build succeeded: |
Previously, pg_catalog didn't include pg_stat* empty stubs
This was inadequate because tools try to use these tables and fail
To address this, this patch adds empty stubs for pg_stats tables
Release note (sql change): Added empty pg_stat* tables on pg_catalog
pg_stat_all_indexes
pg_stat_all_tables
pg_stat_archiver
pg_stat_bgwriter
pg_stat_gssapi
pg_stat_progress_analyze
pg_stat_progress_basebackup
pg_stat_progress_cluster
pg_stat_progress_create_index
pg_stat_progress_vacuum
pg_stat_replication
pg_stat_slru
pg_stat_ssl
pg_stat_subscription
pg_stat_sys_indexes
pg_stat_sys_tables
pg_stat_user_functions
pg_stat_user_indexes
pg_stat_user_tables
pg_stat_wal_receiver
pg_stat_xact_all_tables
pg_stat_xact_sys_tables
pg_stat_xact_user_functions
pg_stat_xact_user_tables
pg_statio_all_indexes
pg_statio_all_sequences
pg_statio_all_tables
pg_statio_sys_indexes
pg_statio_sys_sequences
pg_statio_sys_tables
pg_statio_user_indexes
pg_statio_user_sequences
pg_statio_user_tables
Fixes #67690