Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlliveness/slstorage: record and log when deleting a session #68476

Merged

Conversation

ajwerner
Copy link
Contributor

@ajwerner ajwerner commented Aug 5, 2021

There are two paths which delete sessions: a background job and on demand
when there's a cache miss. The second one, added later, and more commonly hit
did not log or record metrics.

Release note (ops change): Record a log event and counter increment when
removing an expired session.

There are two paths which delete sessions: a background job and on demand
when there's a cache miss. The second one, added later, and more commonly hit
did not log or record metrics.

Release note (ops change): Record a log event and counter increment when
removing an expired session.
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rimadeodhar)

@ajwerner
Copy link
Contributor Author

ajwerner commented Aug 6, 2021

TFTR!

bors r=knz

@craig
Copy link
Contributor

craig bot commented Aug 6, 2021

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Aug 6, 2021

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 69a935a to blathers/backport-release-20.2-68476: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 20.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants