backupccl: add option to display descriptor ids to SHOW BACKUP #68540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhu713
requested review from
a team and
nihalpednekar
and removed request for
a team
|
This change is |
Previously there weren't any descriptor ID information displayed by SHOW BACKUP. These IDs provide useful information during triage and general debugging. To address this, a WITH option debug_ids was added to populate additional columns in SHOW BACKUP with descriptor IDS of all objects along with the IDs of its database and parent schema. Release note (enterprise change): Descriptor IDs of every object are now visible in SHOW BACKUP, along with the descriptor IDs of the object's database and parent schema. SHOW BACKUP will display these IDs if the `WITH debug_ids` option is specified.
dt
approved these changes
Aug 6, 2021
|
bors r+ |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Aug 6, 2021
68540: backupccl: add option to display descriptor ids to SHOW BACKUP r=rhu713 a=rhu713 Previously there weren't any descriptor ID information displayed by SHOW BACKUP. These IDs provide useful information during triage and general debugging. To address this, a WITH option debug_ids was added to populate additional columns in SHOW BACKUP with descriptor IDS of all objects along with the IDs of its database and parent schema. Release note (enterprise change): Descriptor IDs of every object are now visible in SHOW BACKUP, along with the descriptor IDs of the object's database and parent schema. SHOW BACKUP will display these IDs if the `WITH debug_ids` option is specified. Co-authored-by: Rui Hu <rui@cockroachlabs.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there weren't any descriptor ID information displayed by SHOW BACKUP. These IDs provide
useful information during triage and general debugging. To address this, a WITH option debug_ids
was added to populate additional columns in SHOW BACKUP with descriptor IDS of all objects along
with the IDs of its database and parent schema.
Release note (enterprise change): Descriptor IDs of every object are now visible in SHOW BACKUP,
along with the descriptor IDs of the object's database and parent schema. SHOW BACKUP will display
these IDs if the
WITH debug_idsoption is specified.