Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.2: changefeedccl: allow configuring changefeeds to wait for all replicas #69016

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

HonoreDB
Copy link
Contributor

Backport 1/1 commits from #67504.

/cc @cockroachdb/release


… to ack

Changefeeds use Sarama's default config of RequiredAcks: WaitForLocal,
meaning it considers a write to Kafka successful once the leader node has
acked it. This carries a risk of dropped messages if the leader node acks
before replicating to a quorum of other Kafka nodes, then fails.
This PR allows overriding the config like so:

CREATE CHANGEFEED ... WITH kafka_sink_config='{"RequiredAcks": "ALL"}';

It's also now possible to increase throughput by decreasing consistency:

CREATE CHANGEFEED ... WITH kafka_sink_config='{"RequiredAcks": "NONE"}';

Release note (enterprise change): kafka_sink_config can include RequiredAcks

Closes #67368

Release justification: Urgently-requested feature, purely additive

… to ack

Changefeeds use Sarama's default config of `RequiredAcks: WaitForLocal`,
meaning it considers a write to Kafka successful once the leader node has
acked it. This carries a risk of dropped messages if the leader node acks
before replicating to a quorum of other Kafka nodes, then fails.
This PR allows overriding the config like so:

`CREATE CHANGEFEED ...  WITH kafka_sink_config='{"RequiredAcks": "ALL"}';`

It's also now possible to increase throughput by decreasing consistency:

`CREATE CHANGEFEED ...  WITH kafka_sink_config='{"RequiredAcks": "NONE"}';`

Release note (enterprise change): kafka_sink_config can include RequiredAcks
@HonoreDB HonoreDB requested review from a team and nihalpednekar and removed request for a team August 16, 2021 21:31
@blathers-crl
Copy link

blathers-crl bot commented Aug 16, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@HonoreDB HonoreDB requested review from stevendanna and miretskiy and removed request for nihalpednekar August 16, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants