release-20.2: changefeedccl: allow configuring changefeeds to wait for all replicas #69016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #67504.
/cc @cockroachdb/release
… to ack
Changefeeds use Sarama's default config of
RequiredAcks: WaitForLocal
,meaning it considers a write to Kafka successful once the leader node has
acked it. This carries a risk of dropped messages if the leader node acks
before replicating to a quorum of other Kafka nodes, then fails.
This PR allows overriding the config like so:
CREATE CHANGEFEED ... WITH kafka_sink_config='{"RequiredAcks": "ALL"}';
It's also now possible to increase throughput by decreasing consistency:
CREATE CHANGEFEED ... WITH kafka_sink_config='{"RequiredAcks": "NONE"}';
Release note (enterprise change): kafka_sink_config can include RequiredAcks
Closes #67368
Release justification: Urgently-requested feature, purely additive