cli,sql/sem/builtins: emit_defaults to false for decode-proto, pb_to_json #69185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Aug 20, 2021
…_to_json When `cockroach debug decode-proto` and `crdb_internal.pb_to_json` were first added, they emitted the default values in the produced json. This turns out to not be desirable; setting emit defaults to false produces json which round- trips back to the same proto. Release note (cli change): `cockroach debug decode-proto` now does not emit default values by default. Release note (sql change): `crdb_internal.pb_to_json` now does not emit default values by default.
ajwerner
force-pushed
the
ajwerner/decode-proto-emit-defaults-false
branch
from
52ee4f4
to
2753a47
Compare
|
bors r=dt |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
cockroach debug decode-protoandcrdb_internal.pb_to_jsonwere firstadded, they emitted the default values in the produced json. This turns out to
not be desirable; setting emit defaults to false produces json which round-
trips back to the same proto.
Release note (cli change):
cockroach debug decode-protonow does not emitdefault values by default.
Release note (sql change):
crdb_internal.pb_to_jsonnow does not emitdefault values by default.