ui: fix tooltip text on stmt and txn pages #69577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all reset SQL stats tooltips were showing the wrong setting and always mentioning Statement history, instead of Transaction history. Fixes cockroachdb#68462 Release justification: Category 2 Release note (ui change): Fix tooltip text on Statement and Transaction pages, to use correct setting "diagnostics.sql_stat_reset.interval", instead of the previous value "diagnostics.reporting.interval"
|
This change is |
matthewtodd
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all reset SQL stats tooltips were showing the
wrong setting and always mentioning Statement history, instead
of Transaction history.
Fixes #68462
Release justification: Category 2
Release note (ui change): Fix tooltip text on Statement and Transaction
pages, to use correct setting "diagnostics.sql_stat_reset.interval", instead
of the previous value "diagnostics.reporting.interval"