sql: bump default value for sql.stats.persisted_rows.max #69667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained
Previsouly, sql.stats.persisted_rows.max has a default value of 10,000 rows. This is significantly lower than even the in-memory fingerprint count limits (100,000 entries). This commit bumps the default value for sql.stats.persisted_rows.max to 1,000,000 rows. With average row size = 1 KiB, this is equivalent of 1 GiB limit for system.statement_statistics and system.transaction_statistics tables respectively. Release justification: Bug fixes and low-risk updates to new functionality Release note (sql change): sql.stats.persisted_rows.max's default value is now 1,000,000.
Azhng
force-pushed
the
sqlstats-bump-max-rows
branch
from
ef3226e
to
f5fa035
Compare
|
TFTR! bors r=maryliag |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previsouly, sql.stats.persisted_rows.max has a default value
of 10,000 rows. This is significantly lower than even the
in-memory fingerprint count limits (100,000 entries).
This commit bumps the default value for sql.stats.persisted_rows.max
to 1,000,000 rows. With average row size = 1 KiB, this is equivalent
of 1 GiB limit for system.statement_statistics and
system.transaction_statistics tables respectively.
Release justification: Bug fixes and low-risk updates to new
functionality
Release note (sql change): sql.stats.persisted_rows.max's default
value is now 1,000,000.