Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: apply zone configs for copied INDEX for ALTER PK on RBR tables #69681

Merged
merged 1 commit into from Sep 1, 2021

Conversation

otan
Copy link
Contributor

@otan otan commented Sep 1, 2021

Release justification: bug fix for existing feature

Release note (bug fix): Previously, when using ALTER PRIMARY KEY on a
REGIONAL BY ROW table, the copied unique index from the old PRIMARY KEY
would not have the correct zone configurations applied. This commit
fixes that. Users who encountered this bug should re-create the
index.

@otan otan requested review from ajstorm and a team September 1, 2021 04:57
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan changed the title sql: applied zone configs for copied INDEX for ALTER PK on RBR tables sql: apply zone configs for copied INDEX for ALTER PK on RBR tables Sep 1, 2021
@otan otan added the backport-21.1.x 21.1 is EOL label Sep 1, 2021
Release justification: bug fix for existing feature

Release note (bug fix): Previously, when using ALTER PRIMARY KEY on a
REGIONAL BY ROW table, the copied unique index from the old PRIMARY KEY
would not have the correct zone configurations applied. This commit
fixes that. Users who encountered this bug should re-create the
index.
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajstorm)

@otan
Copy link
Contributor Author

otan commented Sep 1, 2021

bors r=ajwerner

@craig
Copy link
Contributor

craig bot commented Sep 1, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-21.1.x 21.1 is EOL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants