Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authors: add <Jack Wu> to authors #69889

Merged
merged 1 commit into from Sep 9, 2021
Merged

authors: add <Jack Wu> to authors #69889

merged 1 commit into from Sep 9, 2021

Conversation

jackcwu
Copy link
Contributor

@jackcwu jackcwu commented Sep 7, 2021

Release note: None

@jackcwu jackcwu requested a review from jlinder September 7, 2021 19:35
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 7, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jlinder
Copy link
Collaborator

jlinder commented Sep 7, 2021

Hi @jackcwu, Can you amend your commit to include the Release justification: non-production change line?

This can be done like so:

  • amend the commit with git commit --amend
  • push the new branch head to your remote with git push --force-with-lease FORK_NAME jackwu_authors

@jackcwu
authors: add <Jack Wu> to authors
3a17989 
Release note: None
Release justification: non-production change
@jackcwu
Copy link
Contributor Author

jackcwu commented Sep 9, 2021

@jlinder My apologies for not seeing this, it got buried under some emails. I just made the change

jlinder
jlinder approved these changes Sep 9, 2021
View reviewed changes
Copy link
Collaborator

@jlinder jlinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jackcwu)

@jackcwu
Copy link
Contributor Author

jackcwu commented Sep 9, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 9, 2021

Already running a review

@craig
Copy link
Contributor

craig bot commented Sep 9, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Sep 9, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Sep 9, 2021

Build succeeded:

@craig craig bot merged commit 62c5be5 into cockroachdb:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlinder jlinder jlinder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackcwu @cockroach-teamcity @jlinder