-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-21.2: sql: support for temporary table clean up for tenants #70129
Conversation
Fixes: cockroachdb#67401 Previously, the temporary table clean up did not execute for tenants. This was inadequate that temporary tables would last longer then the life span of user sessions. To address this, this patch adds support for cleaning up on a single tenant pod. Specifically removing checks for meta1 lease when under a tenant, and support for listing sessions. Release justification: low risk and fixes a tenant related bug Release note (bug fix): Temporary tables were not properly cleaned up for tenants.
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 0 LGTMs obtained
@fqazi any reason why this backport is just for one of the commits on the PR? One backport we're trying to put in is dependent on some functions you added on the other commit not included on this backport |
@maryliag It was intentional because 21.2 did not support tenants across multiple pods. So, we can get away with the first commit, which was a simpler fix. The second commit took the fix further and added RPC logic to support multiple pods. |
Backport 1/2 commits from #69486.
/cc @cockroachdb/release
Fixes #67401
Fixes: #67401
Previously, the temporary table clean-up did not execute for
tenants. This was inadequate that temporary tables would last
longer than the life span of user sessions. To address this,
this patch adds support for cleaning up on a single tenant
pod. Specifically removing checks for meta1 lease when under
a tenant, and support for listing sessions.
Release justification: low risk and fixes a tenant-related bug
Release note (bug fix): Temporary tables were not properly cleaned up for
tenants.