Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: support for temporary table clean up for tenants #70129

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Sep 13, 2021

Backport 1/2 commits from #69486.

/cc @cockroachdb/release

Fixes #67401


Fixes: #67401
Previously, the temporary table clean-up did not execute for
tenants. This was inadequate that temporary tables would last
longer than the life span of user sessions. To address this,
this patch adds support for cleaning up on a single tenant
pod. Specifically removing checks for meta1 lease when under
a tenant, and support for listing sessions.

Release justification: low risk and fixes a tenant-related bug
Release note (bug fix): Temporary tables were not properly cleaned up for
tenants.

Fixes: cockroachdb#67401

Previously, the temporary table clean up did not execute for
tenants. This was inadequate that temporary tables would last
longer then the life span of user sessions. To address this,
this patch adds support for cleaning up on a single tenant
pod. Specifically removing checks for meta1 lease when under
a tenant, and support for listing sessions.

Release justification: low risk and fixes a tenant related bug
Release note (bug fix): Temporary tables were not properly cleaned up for
tenants.
@fqazi fqazi requested a review from ajwerner September 13, 2021 15:45
@blathers-crl
Copy link

blathers-crl bot commented Sep 13, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@ajwerner ajwerner merged commit bc07077 into cockroachdb:release-21.2 Sep 14, 2021
@maryliag
Copy link
Contributor

@fqazi any reason why this backport is just for one of the commits on the PR? One backport we're trying to put in is dependent on some functions you added on the other commit not included on this backport

@fqazi
Copy link
Collaborator Author

fqazi commented Sep 25, 2021

@fqazi any reason why this backport is just for one of the commits on the PR? One backport we're trying to put in is dependent on some functions you added on the other commit not included on this backport

@maryliag It was intentional because 21.2 did not support tenants across multiple pods. So, we can get away with the first commit, which was a simpler fix. The second commit took the fix further and added RPC logic to support multiple pods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: session-scoped temporary objects do not work with tenant clusters
4 participants