Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: correct CLUSTER SETTING hint for sql.defaults.datestyle.enabled #70900

Merged
merged 1 commit into from Nov 16, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 30, 2021

Backport 1/1 commits from #70842 on behalf of @otan.

/cc @cockroachdb/release


Release note (bug fix): Fix an incorrect bug hint for
sql.defaults.datestyle.enabled.


Release justification: fix for existing funtionality

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-70842 branch from 614e54c to e8f9655 Compare September 30, 2021 01:15
@blathers-crl blathers-crl bot requested a review from rafiss September 30, 2021 01:15
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 30, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (bug fix): Fix an incorrect bug hint for
`sql.defaults.datestyle.enabled`.
@otan otan force-pushed the blathers/backport-release-21.2-70842 branch from e8f9655 to fbc5545 Compare November 15, 2021 20:51
@otan otan merged commit b161573 into release-21.2 Nov 16, 2021
@otan otan deleted the blathers/backport-release-21.2-70842 branch November 16, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants