server: remove "experimental" label from OIDC settings #71183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, the OIDC feature was marked "experimental" because it was developed for a specific use-case and we wanted to leave ourselves the option to evolve the settings API in the next version in case new roadblocks came up to adoption. Now that the feature has been available for two major version without any revisions to the cluster settings it's time to remove this labeling. Release note (api change): OIDC support for DB Console is no longer marked as "experimental"
|
This change is |
knz
approved these changes
Oct 5, 2021
thtruo
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
LGTM
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @taroface)
|
@dhartunian Should we also remove the "experimental" callout here? https://www.cockroachlabs.com/docs/v21.2/sso.html Should the v21.1 callout also be removed? Let me know if you'd prefer that I handle this in a separate PR. |
|
@taroface yep, I think we can remove both callouts. At this point we can treat the API as "stable" and any changes should be made in a backwards compatible way. thx |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the OIDC feature was marked "experimental" because it was
developed for a specific use-case and we wanted to leave ourselves the
option to evolve the settings API in the next version in case new
roadblocks came up to adoption.
Now that the feature has been available for two major version without
any revisions to the cluster settings it's time to remove this labeling.
Release note (api change): OIDC support for DB Console is no longer
marked as "experimental"