Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: correct spelling mistakes #71642

Merged
merged 1 commit into from
Oct 25, 2021
Merged

misc: correct spelling mistakes #71642

merged 1 commit into from
Oct 25, 2021

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 17, 2021

This goal of this PR is to be limited to just code comments as suggested in:
#71464 (comment)

@jsoref jsoref requested a review from a team October 17, 2021 01:20
@jsoref jsoref requested review from a team as code owners October 17, 2021 01:20
@jsoref jsoref requested a review from a team October 17, 2021 01:20
@jsoref jsoref requested a review from a team as a code owner October 17, 2021 01:20
@jsoref jsoref requested a review from a team October 17, 2021 01:20
@jsoref jsoref requested review from a team as code owners October 17, 2021 01:20
@jsoref jsoref requested review from shermanCRL and erikgrinaker and removed request for a team October 17, 2021 01:20
@blathers-crl
Copy link

blathers-crl bot commented Oct 17, 2021

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Oct 17, 2021
@cockroach-teamcity
Copy link
Member

This change is Reviewable

jsoref
jsoref commented Oct 17, 2021
View reviewed changes
pkg/base/node_id.go Show resolved Hide resolved
pkg/cli/clisqlclient/conn.go Outdated Show resolved Hide resolved
pkg/cli/interactive_tests/test_txn_prompt.tcl Show resolved Hide resolved
pkg/cmd/roachprod/main.go Outdated Show resolved Hide resolved
pkg/cmd/roachprod/vm/vm.go Outdated Show resolved Hide resolved
pkg/testutils/lint/passes/passesutil/passes_util.go Show resolved Hide resolved
pkg/testutils/pgtest/datadriven.go Show resolved Hide resolved
pkg/ts/iterator_test.go Show resolved Hide resolved
pkg/ts/iterator_test.go Show resolved Hide resolved
pkg/testutils/lint/passes/forbiddenmethod/analyzers.go Show resolved Hide resolved
stevendanna
stevendanna reviewed Oct 18, 2021
View reviewed changes
pkg/cli/cliflags/flags.go Show resolved Hide resolved
pkg/cli/clisqlclient/conn.go Outdated Show resolved Hide resolved
pkg/cmd/roachprod/vm/vm.go Outdated Show resolved Hide resolved
pkg/geo/geographiclib/geodesic.c Outdated Show resolved Hide resolved
pkg/jobs/registry.go Outdated Show resolved Hide resolved
pkg/jobs/registry.go Outdated Show resolved Hide resolved
pkg/jobs/registry.go Outdated Show resolved Hide resolved
@irfansharif irfansharif removed request for a team and shermanCRL October 18, 2021 13:38
@irfansharif irfansharif removed the request for review from erikgrinaker October 18, 2021 13:38
@blathers-crl
Copy link

blathers-crl bot commented Oct 19, 2021

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

irfansharif
irfansharif reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, will merge after addressing a few minor comments.

pkg/cmd/roachprod/main.go Outdated Show resolved Hide resolved
pkg/geo/geographiclib/geodesic.c Outdated Show resolved Hide resolved
pkg/roachpb/io-formats.proto Show resolved Hide resolved
pkg/server/serverpb/status.proto Outdated Show resolved Hide resolved
pkg/settings/settings_test.go Outdated Show resolved Hide resolved
pkg/storage/mvcc.go Show resolved Hide resolved
pkg/cli/clisqlshell/sql.go Outdated
@@ -1937,7 +1937,7 @@ func (c *cliState) serverSideParse(sql string) (helpText string, err error) {
// the constant string parser.helpHintPrefix.
//
// However, we cannot include the 'parser' package here because it
// would incur a hughe dependency overhead.
// would incur a hugh dependency overhead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "huge".

@jsoref jsoref requested review from a team and stevendanna and removed request for a team October 25, 2021 12:56
irfansharif
irfansharif approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge on green CI. Only amended your commit with the necessary make generate. Thanks again for your PR Josh!

knz
knz reviewed Oct 25, 2021
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed just the proto files for accidental api changes. LGTM.

Reviewed 27 of 123 files at r1, 3 of 22 files at r2.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis, @jsoref, and @stevendanna)

@jsoref jsoref requested a review from a team as a code owner October 25, 2021 15:44
@irfansharif
Copy link
Contributor

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 25, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 25, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 25, 2021

Build succeeded:

@craig craig bot merged commit c5ca3a6 into cockroachdb:master Oct 25, 2021
@jsoref jsoref deleted the spelling-misc branch October 25, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knz knz knz left review comments

@irfansharif irfansharif irfansharif approved these changes

@jordanlewis jordanlewis Awaiting requested review from jordanlewis

@stevendanna stevendanna Awaiting requested review from stevendanna

Assignees
No one assigned
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsoref @cockroach-teamcity @irfansharif @knz @stevendanna