vendor: bump panicparse version to v2.2.0 #71690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps our dependency on `github.com/maruel/panicparse` to version v2.2.0. Doing so has two effects. First, doing so unblocks support for go1.17 in cockroachdb. We upstreamed go1.17 support to panicparse in github.com/maruel/panicparse/commit/5825e8fb04831f02e915425d173c580e83fd3f8c, and this upgrade picks this change up. This change was needed because go1.17 changed the format of stack traces, see https://tip.golang.org/doc/go1.17#compiler. Pulling in this change fixes unit tests and introspection endpoints (`/debug/pprof/goroutineui/`) that depend on panicparse. Second, doing so pulls in an improved goroutine UI. Since our initial integration of panicparse, the library has improved the UI significantly. It has also exported the HTML generation code path, so we can delete some code that we lifted from the library. This leads to a `/debug/pprof/goroutineui/` that looks like: <image> Release notes (ui change): the /debug/pprof/goroutineui/ page has a new and improved look.
|
This change is |
|
I confirmed that with this change, |
tbg
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Nice! Does this show labels or would it have to be based on the ?debug=1 format (which it isn't)?
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rickystewart)
Unfortunately, it does not. That information is not included in bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #69603.
This commit bumps our dependency on
github.com/maruel/panicparseto version v2.2.0. Doing so has two effects.First, doing so unblocks support for go1.17 in cockroachdb. We upstreamed go1.17 support to panicparse in maruel/panicparse@5825e8f, and this upgrade picks this change up. This change was needed because go1.17 changed the format of stack traces, see https://tip.golang.org/doc/go1.17#compiler. Pulling in this change fixes unit tests and introspection endpoints (
/debug/pprof/goroutineui/) that depend on panicparse.Second, doing so pulls in an improved goroutine UI. Since our initial integration of panicparse, the library has improved the UI significantly. It has also exported the HTML generation code path, so we can delete some code that we lifted from the library. This leads to a
/debug/pprof/goroutineui/that looks like:Release notes (ui change): the /debug/pprof/goroutineui/ page has a new and improved look.