release-21.2: server: avoid panic in NodesUI #71756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #71749 on behalf of @tbg.
/cc @cockroachdb/release
NodesUI wasn't checking an error and could trigger an NPE in that way.
I found this in a most comical way, by standing up a three node
roachprod cluster and creating an asymmetric network partition where
n2 wasn't able to contact n1:
I don't think this was ever released; the problem was introduced in
PR #71181, on 2021-10-11.
Release note (bug fix): CockroachDB could crash if network connectivity
was impaired. The stack trace (in cockroach-stderr.log) would contain
server.(*statusServer).NodesUI
in that case.Release justification: