Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-21.2: Add Rows Written to Transaction and Statement pages #72006

Merged
merged 2 commits into from
Nov 15, 2021
Merged

release-21.2: Add Rows Written to Transaction and Statement pages #72006

merged 2 commits into from
Nov 15, 2021

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Oct 26, 2021 •
edited
Loading

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release justification: Category 4

@lindseyjin @maryliag
roachpb/sql/ui: add mean rows written to Statement Details page
dc117d9 
Resolves cockroachdb#67084

Previously, the Statement Details page did not show the mean rows
written to. We received feedback to surface rows affected.

To address this, we are adding "mean rows written" to non-SELECT
statements. This has been added as a row on the Statement Details
Overview page and on the Execution Stats "Other Execution Stats" table.
A future PR will also add this new metric to the column selector on
the Statements Overview page.

Release note (ui change): add mean rows written to statement details page
@lindseyjin @maryliag
ui: add rows written to statement and transaction tables
6e7920c 
Resolves cockroachdb#67084

Previously, the Statements and Transactions tables did not have a
"Rows Written" column. This was inadequate as we received feedback
to surface information on Rows Affected for statements on the db
console.

Since we've already added "Rows Written" as a metric on the Statement
Details pages, this commit also adds this metric as a column on the
Statements Overview table. This commit also adds this metric as a field
on the Transaction Statistics proto, in order to add this as a column
on the Transactions table and as a field on the Transaction Details page.
The table columns will not show up by default, although they are
selectable from the column selector.

Release note (ui change): A new column, "Rows Written" has been added
onto the Statements and Transactions tables. This column will not show
up by default, but can be selected from the column selector. A new
metric "Mean rows written" has also been added to the Transaction
Details page.
@maryliag maryliag requested a review from a team as a code owner October 26, 2021 22:28
@blathers-crl
Copy link

blathers-crl bot commented Oct 26, 2021 •
edited by maryliag
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@maryliag maryliag marked this pull request as draft October 26, 2021 22:28
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag removed the request for review from a team October 26, 2021 22:28
@maryliag maryliag added the do-not-merge bors won't merge a PR with this label. label Oct 27, 2021
@maryliag maryliag requested a review from a team October 27, 2021 15:18
@maryliag maryliag marked this pull request as ready for review October 27, 2021 15:18
matthewtodd
matthewtodd approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the branch and ran locally, :lgtm:

Reviewed 16 of 16 files at r1, 20 of 20 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@maryliag maryliag merged commit 63be22a into cockroachdb:release-21.2 Nov 15, 2021
This was referenced Nov 15, 2021
Closed
Closed
@maryliag maryliag deleted the backport21.2-70377-70593 branch November 15, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewtodd matthewtodd matthewtodd approved these changes

Assignees
No one assigned
Labels
do-not-merge bors won't merge a PR with this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maryliag @cockroach-teamcity @matthewtodd @lindseyjin