tracing: fix tracer closing #72443
Merged
tracing: fix tracer closing #72443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ContextWithRecording span was closing the passed-in Tracer, which is completely wrong. This has been broken since a long time ago; the function originally was written to create its own Tracer but then changed to take in a Tracer and the bad close remained. As a practical consequence, tracing to external tracers stopped whenever one of the debug pages that uses this utility was used. Release note (bug fix): Fixed a bug causing tracing to external tracers to inadvertently stop after the Enqueue Range or the Allocator debug pages was used.
|
This change is |
abarganier
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @irfansharif)
|
bors r+ |
|
Build succeeded: |
This was referenced Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContextWithRecording span was closing the passed-in Tracer, which is
completely wrong. This has been broken since a long time ago; the
function originally was written to create its own Tracer but then
changed to take in a Tracer and the bad close remained.
As a practical consequence, tracing to external tracers stopped whenever
one of the debug pages that uses this utility was used.
Release note (bug fix): Fixed a bug causing tracing to external tracers
to inadvertently stop after the Enqueue Range or the Allocator debug
pages was used.