Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: populate indexprs column of pg_catalog.pg_index #72870

Merged
merged 1 commit into from Nov 22, 2021

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Nov 17, 2021

Backport 1/1 commits from #72238.

/cc @cockroachdb/release


sql: populate indexprs column of pg_catalog.pg_index

This commit also fixes the formatting of user-defined types in the
indexdef column of pg_catalog.pg_indexes and the indpred column of
pg_catalog.pg_index.

Release note (bug fix): The indexprs column of pg_catalog.pg_index
is now populated with string representations of every expression element
in the index. If the index is not an expression index, indexprs is
NULL. The indexdef column of pg_catalog.pg_indexes and the
indpred column of pg_catalog.pg_index now correctly display
user-defined types.

@blathers-crl
Copy link

blathers-crl bot commented Nov 17, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit also fixes the formatting of user-defined types in the
`indexdef` column of `pg_catalog.pg_indexes` and the `indpred` column of
`pg_catalog.pg_index`.

Release note (bug fix): The `indexprs` column of `pg_catalog.pg_index`
is now populated with string representations of every expression element
in the index. If the index is not an expression index, `indexprs` is
`NULL`. The `indexdef` column of `pg_catalog.pg_indexes` and the
`indpred` column of `pg_catalog.pg_index` now correctly display
user-defined types.
@rafiss rafiss merged commit c705182 into cockroachdb:release-21.2 Nov 22, 2021
@rafiss rafiss deleted the backport21.2-72238 branch November 22, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants