release-21.2: sql,jobs: implement redact.SafeValue for JobID and SessionID #72975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #71062.
/cc @cockroachdb/release
jobspb.JobID is an int64, populated via unique_rowid() at the
point of job creation.
sqlliveness.SessionID is a string but represents an opaque
identifier. In the current implementation, it is the bytes from a V4
UUID.
jobspb.JobIDs currently appear in many log messages and are fairly
valuable when trying to track what happened to a particular job. For
example,
Before:
After:
SessionID's are not logged in many places currently, but I would like
to include them in error messages in the near future.
Release note (ops change): Job IDs and Session IDs are no longer
redacted. These values do not represent sensitive or identifiable
data, but do aid in debugging problems with the jobs system.
Release justification: Low risk change to improve jobs debugability.